Skip to content

Conversation

@chetan
Copy link

@chetan chetan commented Nov 2, 2023

What kind of change does this PR introduce?

Adds the pg_idkit extension

@chetan chetan requested a review from a team as a code owner November 2, 2023 15:38
@chetan
Copy link
Author

chetan commented Nov 3, 2023

I should note that I didn't totally understand all the ccache stuff, so happy to make any changes to fix those bits.

@kav
Copy link

kav commented Nov 3, 2023

I'm not a maintainer so take this with a grain of salt but I think the pattern in the repository would have you set the workdir to /tmp/ rather than /root/ and then add a step at the end to run dpkg-deb to bundle your deb.
RUN dpkg-deb --build --root-owner-group ./pg_idkit/target/release/pg_idkit-pg15/

Then instead of copying the individual files over you can just do a
COPY --from=pg_idkit-source /tmp/*.deb /tmp/

Hope this gets merged soon through, it's a nice package for those of us who uuid

Note: using dpkg-deb, which you may need to install, rather than checkinstall since pgrx produces root based file layouts rather than using make install

@chetan
Copy link
Author

chetan commented Nov 13, 2023

Thanks @kav. I didn't mess around with the toolchain too much to figure out if it would be possible to produce a deb. I'll give this a try and update the PR.

@olirice
Copy link
Contributor

olirice commented Dec 5, 2023

thanks @chetan

we've decided not to support pg_idkit extension on the platform

It's a great project, but it's also a good candidate to be converted into a trusted language extension. Given the relative ease releasing TLEs compared to full extensions, that's the route we'd prefer for this functionality.

Much of it has already been ported here.

@olirice olirice closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants