fix: pgsodium extension custom script #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
soedirgo commented Dec 16, 2022
| grant execute on function pgsodium.crypto_aead_det_decrypt(bytea, bytea, uuid, bytea) to service_role; | ||
| grant execute on function pgsodium.crypto_aead_det_encrypt(bytea, bytea, uuid, bytea) to service_role; | ||
| grant execute on function pgsodium.crypto_aead_det_keygen to service_role; | ||
| grant execute on function pgsodium.crypto_aead_det_noncegen to service_role; |
There was a problem hiding this comment.
This is granted to public, so no need for the grant
soedirgo commented Dec 16, 2022
Comment on lines +9 to +11
| grant execute on function pgsodium.crypto_aead_det_decrypt(bytea, bytea, uuid, bytea) to service_role; | ||
| grant execute on function pgsodium.crypto_aead_det_encrypt(bytea, bytea, uuid, bytea) to service_role; | ||
| grant execute on function pgsodium.crypto_aead_det_keygen to service_role; |
There was a problem hiding this comment.
I have no idea why, but pgsodium/after-create.sql are not run during create extension pgsodium above, but it's run if I recreate the extension (tested on staging). This was the cause of the build failures.
I'll just add these since the grants are supposed to be idempotent.
| Build seems to run fine: https://github.com/supabase/postgres/actions/runs/3712752347/jobs/6294627349 |
| Looks good - let's merge then roll it on staging to check if it's stable and all good and then we can promote it to a non-rc release. |
pcnc approved these changes Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add back tests and address build failures.