Backport postgresql packaging changes done in nixpkgs #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These overlay packages will be removed once the extensions are updated to use the new `buildPgrxExtension` function.
trace: evaluation warning: packer-1.13.1 was overridden with `version` but not `src` at /nix/store/y2ddpvhfvv5pshcrj0jckgz36fm9n3c6-source/nix/devShells.nix:49:17. This is most likely not what you want. In order to properly change the version of a package, override both the `version` and `src` attributes: hello.overrideAttrs (oldAttrs: rec { version = "1.0.0"; src = pkgs.fetchurl { url = "mirror://gnu/hello/hello-${version}.tar.gz"; hash = "..."; }; }) (To silence this warning, set `__intentionallyOverridingVersion = true` in your `overrideAttrs` call.) The previously used version was failing to build: /build/source/src/common/get_check_data.c: In function 'pgr_SPI_getText': /build/source/src/common/get_check_data.c:307:28: error: passing argument 1 of 'DatumGetCString' makes integer from pointer without a cast [-Wint-conversion] 307 | return DatumGetCString(SPI_getvalue(*tuple, *tupdesc, info.colNumber)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * In file included from /build/source/include/c_common/postgres_connection.h:29, from /build/source/src/common/get_check_data.c:27: /nix/store/nn6vpjqlsxxmynwcrsib9agb3hpr5cqj-postgresql-17.4/include/server/postgres.h:335:23: note: expected 'Datum' {aka 'long unsigned int'} but argument is of type 'char *' 335 | DatumGetCString(Datum X) | ~~~~~~^ make[2]: *** [src/common/CMakeFiles/common.dir/build.make:149: src/common/CMakeFiles/common.dir/get_check_data.c.o] Error 1 This was discussed upstream here: https://postgr.es/m/0a997455-5aba-4cf2-a354-d26d8bcbfae6%40technowledgy.de Also applied by nixpkgs here: NixOS/nixpkgs#342026
We cannot use nodejs.libv8 as it is too new for plv8 3.1. We will be able to use it with plv8 3.2.
Backport upstream commit to remove the deprecated darwin framework: NixOS/nixpkgs#398707
Backport of upstream commit NixOS/nixpkgs@cd85a62
Backport of upstream commit NixOS/nixpkgs@0c47767
Backport upstream commit NixOS/nixpkgs@e0464e4
Backport upstream commit NixOS/nixpkgs@149aa98
Backport upstream commit NixOS/nixpkgs@de4ad2a
Backport upstream commit NixOS/nixpkgs@a7fdf22
Backport upstream commit NixOS/nixpkgs@6178e9b
samrose force-pushed the update-nixpkgs branch from 337be4e to dab9e52 Compare samrose force-pushed the update-nixpkgs branch 2 times, most recently from c061085 to 07fb5e2 Compare samrose force-pushed the update-nixpkgs branch 2 times, most recently from 6b51806 to a33cf5d Compare samrose force-pushed the update-nixpkgs branch from 684c4b7 to 21a8f63 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
wip