Skip to content

chore: install pg_graphql extension #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 21, 2022
Merged

chore: install pg_graphql extension #152

merged 9 commits into from
Mar 21, 2022

Conversation

@dragarcia
Copy link
Contributor

@dragarcia dragarcia commented Mar 3, 2022 •
edited
Loading

Installs the pg_graphql extension.
dragarcia
dragarcia commented Mar 3, 2022
View reviewed changes
ansible/tasks/postgres-extensions/19-pg_graphql.yml
Comment on lines 2 to 7
- name: pg_graphql - download libgraphqlparser
git:
repo: https://github.com/graphql/libgraphqlparser.git
dest: /tmp/libgraphqlparser
version: master
become: yes
Copy link
Contributor Author

@dragarcia dragarcia Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olirice do you have a recommendation/ preferred way to install libgraphqlparser? Their repository hasn't had any new releases since 2017 so the above is just building off from the master branch.
Copy link
Contributor

@olirice olirice Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferred way to install libgraphqlparser

I've been pinning it to the last realease 0.7.0. Heres the install line in the dockerfile used for the quickstart
https://github.com/supabase/pg_graphql/blob/75565af8ef81f0d4e1cf281356d7270c2c6d5a1d/dockerfiles/db/Dockerfile#L13
Copy link
Contributor Author

@dragarcia dragarcia Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it 👍
olirice
olirice reviewed Mar 3, 2022
View reviewed changes
ansible/tasks/postgres-extensions/19-pg_graphql.yml Outdated
pkg:
- clang-11
- build-essential
- python
Copy link
Contributor

@olirice olirice Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python2 is a dependency for installing libgraphqlparser. It shouldn't be required by pg_graphql. did it cause an issue for you?
Copy link
Contributor Author

@dragarcia dragarcia Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is more of a catch all for all packages that would be used by the extension and any other dependencies.
@dragarcia
Copy link
Contributor Author

dragarcia commented Mar 4, 2022

I've updated the steps to instead emulate the steps taken in the Dockerfile. One additional step is to run /sbin/ldconfig -v to update the links and cache for the shared libraries, in particular, /usr/local/lib/libgraphqlparser.so. Beforehand, the following error was returned upon executing create extension if not exists pg_graphql cascade;:

ERROR: could not load library "/usr/lib/postgresql/lib/pg_graphql.so": libgraphqlparser.so: cannot open shared object file: No such file or directory
@dragarcia dragarcia marked this pull request as ready for review March 21, 2022 14:52
@dragarcia
Copy link
Contributor Author

dragarcia commented Mar 21, 2022 •
edited
Loading

All good to go. @oli will let you approve and merge this one in once the final pg_graphql is ready (or if v0.1.1 is already the one).
@olirice olirice merged commit 0940818 into develop Mar 21, 2022
@olirice olirice deleted the chore/pg_graphql branch March 21, 2022 15:55
hf pushed a commit that referenced this pull request Jan 23, 2023
@dragarcia @olirice @hf
chore: install pg_graphql extension (#152)
515b948 
* install pg_graphql extension * install dependencies * update steps to reflect how the docker example is built * update pg_graphql to release v0.1.0 * omit ./bin/pgc build * add pg_graphql to list of extensions to be installed * bump pg_graphql version to v0.1.1 * update pg_graphql release from 0.1.1 to 0.1.2 Co-authored-by: Oliver Rice <github@oliverrice.com>
damonrand pushed a commit to cepro/postgres that referenced this pull request Jun 15, 2025
@dragarcia @olirice
chore: install pg_graphql extension (supabase#152)
253af30 
* install pg_graphql extension * install dependencies * update steps to reflect how the docker example is built * update pg_graphql to release v0.1.0 * omit ./bin/pgc build * add pg_graphql to list of extensions to be installed * bump pg_graphql version to v0.1.1 * update pg_graphql release from 0.1.1 to 0.1.2 Co-authored-by: Oliver Rice <github@oliverrice.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dragarcia @olirice