chore: cleanup flake.nix #1486
Closed
chore: cleanup flake.nix #1486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| inputs = { | ||
| nixpkgs.url = "github:nixos/nixpkgs/nixpkgs-unstable"; | ||
| flake-utils.url = "github:numtide/flake-utils"; | ||
| nix2container.url = "github:nlewo/nix2container"; |
Comment on lines 400 to 411
| inherit | ||
| wal-g | ||
| sfcgal | ||
| supabase-groonga | ||
| postgresql_15 | ||
| postgresql_orioledb-17; | ||
| inherit (pkgs.cargo-pgrx) | ||
| cargo-pgrx_0_11_3 | ||
| cargo-pgrx_0_12_6 | ||
| cargo-pgrx_0_12_9; |
Author
There was a problem hiding this comment.
Preferring the inherit statement is a good practice, also it avoids typos
flake.nix Outdated
Comment on lines 604 to 605
| # TODO: None of these tests are used | ||
| sqlTests = ./nix/tests/smoke; |
Author
There was a problem hiding this comment.
I am not sure if tests are failing or what, but this should be fixed somehow
Collaborator
| Thanks this is a helpful review! |
Collaborator
| Everything looks good. the smoke tests are redundant and the line and files should just be removed. |
gytis-ivaskevicius force-pushed the minor-cleanup branch from 848341f to c85efc2 Compare 
Author
| Removed the smoke tests and rebased to fix merge conflicts |
Collaborator
| This was a good contribution, thank you. We ended up addressing many of these issues albiet in different ways. Thanks for trying to help us improve the codebase never the less. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Minor flake.nix cleanup. My editor auto removes whitespace so I would recommend enabling "hide all whitespace" option when reviewing this PR
More information on specific changes in PR comments