fix: add more logs to the exit path #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
So we can understand better what cause the ending of the container
avallete commented Apr 9, 2025
| adminApp.listen({ port: adminPort, host: PG_META_HOST }, (err) => { | ||
| if (err) { | ||
| app.log.error({ err }, 'Uncaught error in adminApp, exit(1)') | ||
| process.exit(1) |
There was a problem hiding this comment.
note
This one I'm not sure, should we exit 1 in such case ? It seems like this would happen anyways since we'll pass by the hook 'onClose' 🤔
There was a problem hiding this comment.
Let’s leave them in just to be safe?
Pull Request Test Coverage Report for Build 14377261827Details
💛 - Coveralls |
soedirgo approved these changes Apr 10, 2025
avallete added a commit that referenced this pull request May 13, 2025
fix: add more logs to the exit path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
So we can understand better what cause the ending of the container