Skip to content

Conversation

itslenny
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

SIGNED_UPLOAD_URL_EXPIRATION_TIME defaults to 60 seconds, but in production the default is 7200

What is the new behavior?

set SIGNED_UPLOAD_URL_EXPIRATION_TIME to 7200 to match production environment

@itslenny itslenny requested a review from a team as a code owner September 18, 2025 17:59
@itslenny
Copy link
Contributor Author

duplicate... oops.

@itslenny itslenny closed this Sep 18, 2025
@coveralls
Copy link

coveralls commented Sep 18, 2025

Pull Request Test Coverage Report for Build 18021256027

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 54.888%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 18011933542: -0.03%
Covered Lines: 6367
Relevant Lines: 11600

💛 - Coveralls
@itslenny itslenny reopened this Sep 25, 2025
@itslenny
Copy link
Contributor Author

Re-opened because the other PR that I thought this was a duplicate of changed the ENV in the migrate job container instead of the storage api container.

@itslenny itslenny force-pushed the fix/set-local-signed-url-expiration-to-match-prod branch from d512b47 to 7c9df87 Compare September 25, 2025 21:29
@sweatybridge sweatybridge merged commit 05a2f39 into develop Sep 26, 2025
13 of 14 checks passed
@sweatybridge sweatybridge deleted the fix/set-local-signed-url-expiration-to-match-prod branch September 26, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants