Skip to content

Conversation

@juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Sep 5, 2025

  • fix policy completions – seem to be broken

given select | from public.users "u" or select | from public.users u

  • autocomplete with single " -> results in "u"."email" or "email"
  • autocomplete within double "" -> results in "u"."email" or "email"
  • recognize aliases regardless of whether they are quoted or not:
    • "u".| and u.| will both suggest email
    • "u"."| and u."| and "u"."|" and u."|" will all suggest "email"
    • This does not yet work for tables -> separate PR
  • existing behavior without quotes is unaffected
@juleswritescode juleswritescode marked this pull request as ready for review September 9, 2025 11:14
@juleswritescode juleswritescode changed the title draft: autocomplete with single " feat: autocomplete with single " Sep 9, 2025
Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has_uneven_quotes - this is getting ridiculous 😂

Always Sunny Reaction GIF

@juleswritescode juleswritescode enabled auto-merge (squash) September 10, 2025 08:00
@juleswritescode juleswritescode merged commit e2826fb into main Sep 10, 2025
8 checks passed
@juleswritescode juleswritescode deleted the fix/#487 branch October 28, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants