fix(vscode): extension command, server crate path #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
juleswritescode changed the title 
| awesome! 🫶🏼 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
When we install and use the VS Code extension, we're now installing the correct crate and running the correct binary.
I also added already-in-use, non-default settings to the
.prettierrc.jsfile, so that the diff is more readable.What is the current behavior?
Running
cargo xtask installfails because it's looking for apostgres_lspcrate; there is none. The crate is calledpg_lsp.Starting the VSCode extension fails because it tries to execute the
postgres_lspbinary; it's calledpglsp.What is the new behavior?
We're installing the correct crate and executing the correct binary.
It's working now 🥳🥳🥳: