store downloaded archives in DASHT_CACHE_DIR instead of using DASHT_DOCSETS_DIR #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ktetzlaff force-pushed the store-downloaded-archives-in-cache-dir branch from 6d04426 to 1821136 Compare instead of using DASHT_DOCSETS_DIR. This improves interoperability with dash-docs.el (see https://github.com/dash-docs-el/dash-docs) which otherwise tries to open all archives stored in the DOCSETS directory when creating a list of installed docsets (which is a time consuming process and results in a timeout in dash-docs).
ktetzlaff force-pushed the store-downloaded-archives-in-cache-dir branch from 1821136 to ed04679 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This improves interoperability with dash-docs.el (see https://github.com/dash-docs-el/dash-docs) which otherwise tries to open all archives stored in the DOCSETS directory when creating a list of installed docsets (which is a time consuming process and results in a timeout in dash-docs).
Since this is mostly a workaround for an issue with dash-docs.el, feel free to just close the PR without merging it. But if you're interested in a merge, I could try to provide some sort of (automatic?) migration script for existing installations.