Upgrade docker images to alpine 3.21 #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades docker images to address recent CVE issues by moving to Alpine 3.21 for Node-based images and updating the backend image to Python 3.13. Key changes include:
- Switching Node base images from version 20 to 24 (using Alpine 3.21) in frontend Dockerfiles
- Upgrading the backend Python image from 3.12.6-alpine3.20 to 3.13.3-alpine
- Adjusting a test expectation for attachment upload to match new standards
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/servers/y-provider/Dockerfile | Updated Node image base and added system package upgrades |
| src/frontend/Dockerfile | Upgraded Node image and NGINX image; added upgrade commands with a note for future cleanup |
| src/backend/core/tests/documents/test_api_documents_attachment_upload.py | Modified assertion for file ContentType |
| Dockerfile | Upgraded Python image base to Python 3.13 |
| CHANGELOG.md | Documented the docker images upgrade changes |
Comments suppressed due to low confidence (1)
src/backend/core/tests/documents/test_api_documents_attachment_upload.py:413
- Please verify that the updated expected ContentType 'application/x-dosexec' aligns with the intended behavior and security requirements.
assert file_head["ContentType"] == "application/x-dosexec" 
lunika force-pushed the python3.13 branch 3 times, most recently from 5b0999d to 9651829 Compare 
Python 3.13 is now stable, our libraries are compatible with it. We also upgrade the alpine version used in order to fix CVE related to libxml2
We need to upgrade our images to alpine 3.21 in order to fix a CVE related to libxml2. We also upgrade node to version 24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
Several CVE related to libxml2 have been published. To fix them, we need to user images based on alpine 3.21 and upgrade the dependencies.
We also upgrade node and python to a newer version.
Proposal