💄Generic Theme #792
Merged
💄Generic Theme #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AntoLC force-pushed the feature/theme-europe branch 4 times, most recently from c51d9da to edfbe9f Compare AntoLC force-pushed the feature/theme-europe branch 3 times, most recently from 734e834 to 106a5e5 Compare 
| This should be documented, the same way I suggest on the css PR. |
AntoLC force-pushed the feature/theme-europe branch from 106a5e5 to 84b5e2f Compare AntoLC force-pushed the feature/theme-europe branch from 84b5e2f to 3492ea2 Compare AntoLC force-pushed the feature/theme-europe branch from 6eb903f to 0982285 Compare 
AntoLC force-pushed the feature/theme-europe branch 2 times, most recently from 2e34dba to d150e4d Compare 
rvveber requested changes Apr 16, 2025
src/frontend/apps/impress/src/features/footer/api/useFooter.tsx Outdated Show resolved Hide resolved
| I've deployed this theme on my server, and after using it, I think it lacks of colours... |
| I guess @soyouzpanda is right. Maybe using the blue as primary color on buttons not just on hoover? what do you think @rl-83 ? |
13 tasks
2 tasks
AntoLC force-pushed the feature/theme-europe branch from d150e4d to f6136d2 Compare AntoLC force-pushed the refacto/footer-from-json branch 2 times, most recently from ae05629 to 8494fd9 Compare 
virgile-dev previously requested changes May 21, 2025
There was a problem hiding this comment.
@rl-83 could you provide a black favicon with the white stroke please ?
There was a problem hiding this comment.
In brower using dark mode the icon is not too visible.
Using a white stroke like we have in dsfr would improve visibility.
There was a problem hiding this comment.
Let's create a issue about it.
🚢🚢🚢
AntoLC force-pushed the refacto/footer-from-json branch from 8494fd9 to 7a38395 Compare AntoLC force-pushed the feature/theme-europe branch 2 times, most recently from b94f4d0 to 5e67f81 Compare 
By default Docs will not be on the dsfr theme but on the generic theme. La Gaufre is part of the dsfr theme and is removed from the generic theme. Same for the "beta" keyword and the "proconnect" buttons.
We want to desaturate the images system in the generic theme to make them less colorful and more in line with the overall theme. We added a special class to the images that need to be desaturated. Other property then desaturated can be apply depending on the theme.
The favicons were still with the dsfr color. We added the generic favicon in the assets folder. The favicon can be a url loaded from the theme, so when Drive will be running, we will be able to store the dsfr favicons there, and remove them from the repo.
Remove: - FRONTEND_FOOTER_FEATURE_ENABLED - FRONTEND_FOOTER_URL
AntoLC force-pushed the feature/theme-europe branch from 5e67f81 to d87a2ed Compare Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
The DSFR theme has some elements not compatible with the open source usage, like the Marianne Font, La Gauffre, the Marianne Logo, the footer.
Proposal
Demo