Skip to content

Conversation

@AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Mar 21, 2025

Purpose

The DSFR theme has some elements not compatible with the open source usage, like the Marianne Font, La Gauffre, the Marianne Logo, the footer.

Proposal

  • We change the theme to be more generic
  • We removed all the elements linked to the "design system de l'état" (dsfr)

  • ✨(frontend) create generic theme

Demo

image
image

@AntoLC AntoLC added the wip label Mar 21, 2025
@AntoLC AntoLC self-assigned this Mar 21, 2025
@AntoLC AntoLC marked this pull request as draft March 21, 2025 17:01
@AntoLC AntoLC mentioned this pull request Mar 24, 2025
9 tasks
@AntoLC AntoLC force-pushed the feature/theme-europe branch 4 times, most recently from c51d9da to edfbe9f Compare March 25, 2025 14:56
@AntoLC AntoLC changed the title theme europe 💄Theme Europe Mar 25, 2025
@AntoLC AntoLC added frontend feature add a new feature backend and removed wip labels Mar 25, 2025
@AntoLC AntoLC force-pushed the feature/theme-europe branch 3 times, most recently from 734e834 to 106a5e5 Compare March 25, 2025 16:13
@AntoLC AntoLC marked this pull request as ready for review March 26, 2025 20:02
@virgile-dev virgile-dev self-requested a review March 27, 2025 10:51
@AntoLC AntoLC requested review from NathanVss, lunika and rl-83 March 27, 2025 11:50
@lunika
Copy link
Member

lunika commented Mar 27, 2025

This should be documented, the same way I suggest on the css PR.

@virgile-dev virgile-dev changed the title 💄Theme Europe 💄Generic Theme Apr 2, 2025
@AntoLC AntoLC force-pushed the feature/theme-europe branch from 106a5e5 to 84b5e2f Compare April 4, 2025 14:22
@AntoLC AntoLC linked an issue Apr 4, 2025 that may be closed by this pull request
@AntoLC AntoLC force-pushed the feature/theme-europe branch from 84b5e2f to 3492ea2 Compare April 8, 2025 07:33
@AntoLC AntoLC requested review from rvveber and virgile-dev April 8, 2025 15:09
@AntoLC AntoLC force-pushed the feature/theme-europe branch from 6eb903f to 0982285 Compare April 10, 2025 11:43
Copy link
Collaborator

@virgile-dev virgile-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@AntoLC AntoLC force-pushed the feature/theme-europe branch 2 times, most recently from 2e34dba to d150e4d Compare April 11, 2025 20:06
rvveber
rvveber approved these changes Apr 16, 2025
@soyouzpanda
Copy link
Contributor

I've deployed this theme on my server, and after using it, I think it lacks of colours...
It's kinda depressing... Can't we have something more cheerful?

@virgile-dev
Copy link
Collaborator

I guess @soyouzpanda is right. Maybe using the blue as primary color on buttons not just on hoover? what do you think @rl-83 ?

@virgile-dev virgile-dev mentioned this pull request May 12, 2025
2 tasks
@AntoLC AntoLC force-pushed the feature/theme-europe branch from d150e4d to f6136d2 Compare May 19, 2025 09:16
@AntoLC AntoLC changed the base branch from main to refacto/footer-from-json May 19, 2025 09:17
@AntoLC AntoLC force-pushed the refacto/footer-from-json branch 2 times, most recently from ae05629 to 8494fd9 Compare May 21, 2025 09:04
Copy link
Collaborator

@virgile-dev virgile-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rl-83 could you provide a black favicon with the white stroke please ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In brower using dark mode the icon is not too visible.
Using a white stroke like we have in dsfr would improve visibility.
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a issue about it.

🚢🚢🚢

@AntoLC AntoLC force-pushed the refacto/footer-from-json branch from 8494fd9 to 7a38395 Compare May 22, 2025 12:08
Base automatically changed from refacto/footer-from-json to main May 22, 2025 12:20
@AntoLC AntoLC force-pushed the feature/theme-europe branch 2 times, most recently from b94f4d0 to 5e67f81 Compare May 22, 2025 12:47
AntoLC added 4 commits May 22, 2025 15:27
By default Docs will not be on the dsfr theme but on the generic theme. La Gaufre is part of the dsfr theme and is removed from the generic theme. Same for the "beta" keyword and the "proconnect" buttons.
We want to desaturate the images system in the generic theme to make them less colorful and more in line with the overall theme. We added a special class to the images that need to be desaturated. Other property then desaturated can be apply depending on the theme.
The favicons were still with the dsfr color. We added the generic favicon in the assets folder. The favicon can be a url loaded from the theme, so when Drive will be running, we will be able to store the dsfr favicons there, and remove them from the repo.
Remove: - FRONTEND_FOOTER_FEATURE_ENABLED - FRONTEND_FOOTER_URL
@AntoLC AntoLC force-pushed the feature/theme-europe branch from 5e67f81 to d87a2ed Compare May 22, 2025 13:42
@AntoLC AntoLC dismissed virgile-dev’s stale review May 22, 2025 13:43

Let's create a issue about it.

🚢🚢🚢

@AntoLC AntoLC merged commit d87a2ed into main May 22, 2025
20 of 21 checks passed
@AntoLC AntoLC deleted the feature/theme-europe branch May 22, 2025 13:55
@AntoLC AntoLC mentioned this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6 participants