♻️(service-worker) improve SW registration and update handling #1473
+9 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AntoLC force-pushed the enhance/sw-register branch 2 times, most recently from d1ea70b to b11366f Compare 
Ovgodd approved these changes Oct 9, 2025
It is apparently a bad practice to add the version number to the service worker file name. This prevents the browser from properly updating the service worker when a new version is available. We improve the update handling by a more usual pattern.
AntoLC force-pushed the enhance/sw-register branch from b11366f to af01c6e Compare 
| Size Change: -10 B (0%) Total Size: 3.66 MB
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
It is apparently a bad practice to add the version number to the service worker file name.
This prevents the browser from properly updating the service worker when a new version is available.
https://web.dev/articles/service-worker-lifecycle#avoid-url-change
We improve the update handling by a more usual pattern.