Skip to content

✨(frontend) add default background to left panel for better accessibi… #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

✨(frontend) add default background to left panel for better accessibi… #1423

merged 1 commit into from
Sep 24, 2025

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Sep 23, 2025 •
edited
Loading

Purpose

Fix visual accessibility issue caused by missing background color in the custom LeftPanel used in DOCS.

issue : 896

Proposal

  • Add default background color to the LeftPanel used in DOCS
  • Ensure alignment with UI Kit behavior, which already defines a background color
  • Improve accessibility for users applying custom styles (e.g., via Stylus extension)

Note: The LeftPanel from the UI Kit has default background color but DOCS uses a custom implementation of a LeftPanel.
@Ovgodd Ovgodd self-assigned this Sep 23, 2025
@Ovgodd Ovgodd force-pushed the fix/896-left-sidebar-bg-color branch from a1b04dd to 43c72f9 Compare September 23, 2025 07:35
@Ovgodd Ovgodd requested a review from AntoLC September 23, 2025 07:36
@Ovgodd Ovgodd force-pushed the fix/896-left-sidebar-bg-color branch from 43c72f9 to 9e6e544 Compare September 23, 2025 07:37
@Ovgodd Ovgodd marked this pull request as ready for review September 23, 2025 07:38
@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Size Change: +11 B (0%)

Total Size: 3.65 MB

Filename Size Change
apps/impress/out/_next/static/ad1f5b13/_buildManifest.js 0 B -865 B (removed) 🏆
apps/impress/out/_next/static/bf7d6635/_buildManifest.js 866 B +866 B (new file) 🆕

compressed-size-action
@Ovgodd Ovgodd force-pushed the fix/896-left-sidebar-bg-color branch from 9e6e544 to 967072d Compare September 23, 2025 09:25
@Ovgodd
✨(frontend) add default background to left panel for better a11y
f337a2a 
defined a default background color to prevent issues with user stylesheets Signed-off-by: Cyril <c.gromoff@gmail.com>
@Ovgodd Ovgodd force-pushed the fix/896-left-sidebar-bg-color branch from 967072d to f337a2a Compare September 24, 2025 09:40
@Ovgodd Ovgodd merged commit f337a2a into main Sep 24, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/896-left-sidebar-bg-color branch September 24, 2025 10:17
@AntoLC AntoLC mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility frontend

3 participants

@Ovgodd @AntoLC