✨(frontend) enable enter key to open documents and subdocuments #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Ovgodd force-pushed the fix/keyboard-activate-doc branch 5 times, most recently from d60dd31 to 884a5a0 Compare Ovgodd force-pushed the fix/keyboard-activate-doc branch from 884a5a0 to a64085f Compare 
| Size Change: +620 B (+0.02%) Total Size: 3.66 MB
|
Ovgodd force-pushed the fix/keyboard-activate-doc branch 6 times, most recently from 2746c9e to 58c0b5d Compare Ovgodd force-pushed the fix/keyboard-activate-doc branch 4 times, most recently from 4bbfebe to cab4f61 Compare 
AntoLC reviewed Sep 11, 2025
src/frontend/apps/impress/src/features/docs/doc-management/components/SimpleDocItem.tsx Outdated Show resolved Hide resolved
Ovgodd force-pushed the fix/keyboard-activate-doc branch from f5323cf to 773b150 Compare AntoLC reviewed Sep 15, 2025
src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx Show resolved Hide resolved
src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx Show resolved Hide resolved
AntoLC reviewed Sep 15, 2025
src/frontend/apps/impress/src/features/docs/doc-tree/components/DocTree.tsx Outdated Show resolved Hide resolved
Ovgodd force-pushed the fix/keyboard-activate-doc branch from 92fbf03 to 104e14f Compare Ovgodd force-pushed the fix/keyboard-activate-doc branch from 104e14f to dd6c64c Compare Ovgodd force-pushed the fix/keyboard-activate-doc branch 2 times, most recently from 1697f78 to 85e27c5 Compare AntoLC reviewed Sep 15, 2025
| $width="100%" | ||
| className="--docs--simple-doc-item" | ||
| role="presentation" | ||
| aria-label={`${t('Open document')} ${doc.title || untitledDocument}`} |
There was a problem hiding this comment.
Suggested change
| aria-label={`${t('Open document')} ${doc.title || untitledDocument}`} | |
| aria-label={`${t('Open document {{title}}', {title: doc.title || untitledDocument})} |
src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx Outdated Show resolved Hide resolved
| $align="center" | ||
| className="light-doc-item-actions" | ||
| role="toolbar" | ||
| aria-label={`${t('Actions for')} ${docTitle}`} |
There was a problem hiding this comment.
Suggested change
| aria-label={`${t('Actions for')} ${docTitle}`} | |
| aria-label={`${t('Actions for {{title}}', {title: ${docTitle}`})} |
src/frontend/apps/impress/src/features/docs/doc-tree/components/DocTree.tsx Outdated Show resolved Hide resolved
There was a problem hiding this comment.
Folder hooks should be out of folder components.
src/frontend/apps/impress/src/features/docs/doc-tree/components/hooks/useKeyboardActivation.ts Outdated Show resolved Hide resolved
Ovgodd force-pushed the fix/keyboard-activate-doc branch from dd030a2 to ee66426 Compare AntoLC approved these changes Sep 16, 2025
| action(); | ||
| } | ||
| }; | ||
| const treeEl = document.querySelector<HTMLElement>('.c__tree-view'); |
There was a problem hiding this comment.
.c__tree-view could be a prop of this hook, it will then be a nice totally generic hook that you could reuse in different part of the app, that could live in src/hook, wdyt ?
Suggested change
| const treeEl = document.querySelector<HTMLElement>('.c__tree-view'); | |
| const elSelected = document.querySelector<HTMLElement>(selector); |
There was a problem hiding this comment.
Great idea! Can't believe I didn't think of that sooner.
AntoLC reviewed Sep 16, 2025
src/frontend/apps/impress/src/features/docs/doc-tree/components/dom-selectors.ts Outdated Show resolved Hide resolved
Ovgodd force-pushed the fix/keyboard-activate-doc branch 2 times, most recently from e9fe0a8 to f1a9252 Compare 
added keyboard support to open docs and subdocs using the enter key Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd force-pushed the fix/keyboard-activate-doc branch 2 times, most recently from 3381269 to e290543 Compare aligns focus state with app style by adding background shadow to outline Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd force-pushed the fix/keyboard-activate-doc branch from e290543 to 69e7235 Compare 
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
Enable keyboard accessibility for opening documents and subdocuments via the Enter key. This improves usability and accessibility for users navigating with the keyboard.
Proposal