✨(frontend) improve modal a11y: structure, labels, and title #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Ovgodd force-pushed the fix/899-modal-a11y branch 3 times, most recently from 62d3cae to 3b10b6e Compare 
| Size Change: +324 B (+0.01%) Total Size: 3.65 MB
|
Ovgodd force-pushed the fix/899-modal-a11y branch 2 times, most recently from f2222ad to 440be24 Compare 
AntoLC reviewed Sep 9, 2025
src/frontend/apps/impress/src/features/docs/doc-export/components/ModalExport.tsx Show resolved Hide resolved
Ovgodd force-pushed the fix/899-modal-a11y branch from edce077 to 26e7886 Compare Ovgodd force-pushed the fix/899-modal-a11y branch from 26e7886 to 1601e78 Compare 
Ovgodd force-pushed the fix/899-modal-a11y branch 2 times, most recently from 8ff6d30 to 9a7b6ac Compare 
added aria-label, structured text in p, and added title for better accessibility Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd force-pushed the fix/899-modal-a11y branch from 9a7b6ac to 8a310d0 Compare 
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
Improve the accessibility of the modal by structuring content properly, adding a descriptive title, and clarifying button labels.
issue : 899
Proposal
The sr-only class hides content from visual display but keeps it readable by screen readers. This ensures assistive technologies can announce the modal's purpose without affecting the UI layout.