🐛(frontend) fix display bug on homepage #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AntoLC force-pushed the fix/display-bug-homepage branch from 41c3a60 to be6af9f Compare 
| Size Change: -4 B (0%) Total Size: 3.64 MB
|
Ovgodd requested changes Sep 4, 2025
| {title} | ||
| </Text> | ||
| <Text | ||
| as="div" |
There was a problem hiding this comment.
I would recommend using a p tag instead of a div for better semantics.
If you want to keep the same visual style without the default margin applied to p, you can simply add:
wdyt ?
Suggested change
| as="div" | |
| $css={css` | |
| margin: 0; | |
| `} | |
| as="p" |
There was a problem hiding this comment.
I don't think we should use a "p" tag here, because it contains "div" and others "p" tag in it.
There was a problem hiding this comment.
Ahh yes, I agree with you, div is a better choice.
A section in the homepage was not displaying correctly anymore. This commit fixes the issue.
AntoLC force-pushed the fix/display-bug-homepage branch from be6af9f to 39ef6d1 Compare Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
A section in the homepage was not displaying correctly anymore. This commit fixes the issue.
Demo