🐛(backend) allow creator to delete subpages #1297
Conversation
| Good point as the owner can still restore from trashbin... |
AntoLC left a comment
AntoLC left a comment There was a problem hiding this comment.
Working as expected, but I find it is lot of power for the editors, I am wondering if an editor should be able to delete only his own subpages.
can_destroy = is_owner or is_admin or is_creator 
| @AntoLC I agree with you ! Let’s go for what you proposed |
lunika force-pushed the fix/editor-can-delete-subpages branch from 4aba797 to c478359 Compare lunika changed the title lunika force-pushed the fix/editor-can-delete-subpages branch from c478359 to c660534 Compare 
| The implementation I made changed a bit. I think it should be reviewed again. |
| Size Change: +5 B (0%) Total Size: 3.6 MB |
| is_owner | ||
| if self.is_root() |
There was a problem hiding this comment.
I don't understand, why admin cannot delete root documents (and I don't see the related test)?
There was a problem hiding this comment.
This is the legacy behavior. And the related test is here https://github.com/suitenumerique/docs/blob/main/src/backend/core/tests/documents/test_api_documents_delete.py#L50
lunika force-pushed the fix/editor-can-delete-subpages branch 3 times, most recently from b866248 to 14fa6a4 Compare 
An editor who created a subpages should be allowed to delete it. We change the abilities to be coherent between the creation and the deletion. Fixes #1193
lunika force-pushed the fix/editor-can-delete-subpages branch from 14fa6a4 to 2e04b63 Compare 
Purpose
An editor who created a subpages should be allowed to delete it.
We change the abilities to be coherent between the creation and the
deletion.
Proposal
Fixes #1193