🎨(frontend) improve nav structure #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Ovgodd force-pushed the fix/916-nav-structure branch from d23f544 to bcdbdee Compare Ovgodd force-pushed the fix/916-nav-structure branch 2 times, most recently from fcb76f7 to 22a32c5 Compare 
AntoLC reviewed Aug 4, 2025
src/frontend/apps/impress/src/features/left-panel/components/LefPanelTargetFilters.tsx Show resolved Hide resolved
Yes I agree ! |
Ovgodd force-pushed the fix/916-nav-structure branch 3 times, most recently from 28e50bb to bc0def2 Compare 
Closed
AntoLC reviewed Aug 5, 2025
src/frontend/apps/impress/src/features/left-panel/components/LeftPanelFavorites.tsx Show resolved Hide resolved
AntoLC reviewed Aug 6, 2025
Comment on lines 36 to 37
| const { colorsTokens: _colorsTokens, spacingsTokens: _spacingsTokens } = | ||
| useCunninghamTheme(); |
There was a problem hiding this comment.
You don't need this part I think.
adds aria-label and focus-visible to improve accessibility Signed-off-by: Cyril <c.gromoff@gmail.com>
make LeftOPanelFavoriteItem accessible, use StyledLinked for target filters Signed-off-by: Cyril <c.gromoff@gmail.com>
aria-current is correct for nav links; test was misaligned with a11y practices Signed-off-by: Cyril <c.gromoff@gmail.com>
improves a11y by using proper list roles and adds missing i18n strings Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd force-pushed the fix/916-nav-structure branch from 1adca17 to c166f86 Compare AntoLC approved these changes Aug 6, 2025
Ovgodd force-pushed the fix/916-nav-structure branch from c166f86 to 0c3cd11 Compare AntoLC reviewed Aug 6, 2025
enhances keyboard access to pin/unpin and syncs test with new behavior Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd force-pushed the fix/916-nav-structure branch from 0c3cd11 to 496800e Compare Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
Improve accessibility of the LeftPanelTargetFilter component by using semantic elements and proper focus management.
issue 879
Proposal