♿️(frontend) keyboard interaction with menu #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Ovgodd force-pushed the fix/877-focus-visible branch from 3b0b9a6 to d07c1e2 Compare Ovgodd force-pushed the fix/877-focus-visible branch 4 times, most recently from abafa1a to 47875b8 Compare 
AntoLC reviewed Jul 31, 2025
| | ||
| const documentTitle = doc.title || t('Untitled document'); | ||
| const menuLabel = t( | ||
| 'Ouvrir le menu des actions pour le document: {{title}}', |
src/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGridActions.tsx Outdated Show resolved Hide resolved
Ovgodd force-pushed the fix/877-focus-visible branch from 1468e2f to 966607e Compare AntoLC reviewed Aug 4, 2025
There was a problem hiding this comment.
I think we should add a test about this part, maybe we can do it by updating this test ?
You could select the language thanks to the keyboard functionally, and assert the selected one is the first that has the focus by example.
There was a problem hiding this comment.
Yes I agree ! :) I putted in the same test
There was a problem hiding this comment.
There is a css latency, caused by transition with outline:
It seems cleaner to remove the transition on this component.
Ovgodd force-pushed the fix/877-focus-visible branch 3 times, most recently from 376a993 to 0613c8f Compare Ovgodd force-pushed the fix/877-focus-visible branch from 659fc2a to b59ddf1 Compare Ovgodd force-pushed the fix/877-focus-visible branch 4 times, most recently from 630d341 to c0372c9 Compare Ovgodd force-pushed the fix/877-focus-visible branch 2 times, most recently from 8e2edd5 to 9a85425 Compare 
Enhances nav for language switch and makes DocsGridActions buttons accessible Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd force-pushed the fix/877-focus-visible branch from 9a85425 to 5181bba Compare 
AntoLC changed the title Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
Unify and improve accessibility across key UI components in the documentation interface.
Proposal