✨(configuration) add configuration Value to support file path in environment #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for environment variables that can reference either a value or the path to a file containing the value, which is particularly useful for securing secrets. Key changes include new tests for SecretFileValue behavior, a new SecretFileValue class in the configuration module, and an updated dependency in pyproject.toml to include django‑configurations.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/configuration/test_secret_file.py | Introduces tests validating different ways to supply secret values. |
| tests/configuration/init.py | Provides a configuration tests initialization file. |
| src/lasuite/configuration/values.py | Implements SecretFileValue to support both file path and direct env values. |
| pyproject.toml | Adds dependency for django‑configurations to support this feature. |
Files not reviewed (1)
- tests/configuration/test_secret: Language not supported
qbey reviewed Apr 29, 2025
soyouzpanda force-pushed the feature/configuration-environment-secrets branch from 451f2bf to fd2a3a7 Compare 
lunika reviewed Apr 29, 2025
soyouzpanda force-pushed the feature/configuration-environment-secrets branch from fd2a3a7 to 1afc245 Compare lunika reviewed May 9, 2025
Member
| You should run |
soyouzpanda force-pushed the feature/configuration-environment-secrets branch 2 times, most recently from d54f4c6 to 8567894 Compare soyouzpanda force-pushed the feature/configuration-environment-secrets branch from 8567894 to 080c9a4 Compare lunika approved these changes May 20, 2025
soyouzpanda force-pushed the feature/configuration-environment-secrets branch 2 times, most recently from 62a33db to 1ee6593 Compare This supports use of environment variables that either reference a value or a path to file containing the value. This is useful for secrets, to avoid the secret to be in a world-readable environment file.
soyouzpanda force-pushed the feature/configuration-environment-secrets branch from 1ee6593 to ea908d9 Compare 
lunika added a commit that referenced this pull request May 20, 2025
Added - ✨(configuration) add configuration Value to support file path in environment #15 Changed - ♻️(malware_detection) retry getting analyse result sooner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related to suitenumerique/docs#912 and suitenumerique/docs#909
This supports use of environment variables that either reference a value or a path to file containing the value. This is useful for secrets, to avoid the secret to be in a world-readable environment file.