Skip to content

Conversation

@amanreddy77
Copy link

Fix hover effect on the navbar which is visually unappealing and incomplete background on hover #280

Description

The "Home" link on the navigation bar was not applying the intended transition and hover effects when the current route was /. The transition-related classes were missing when the route matched '/', causing the hover and animation effects to be inactive.

  • Updated the conditional classes in the Home link to ensure that transition and hover-related classes (transition-all, transform, hover:scale-105, etc.) are applied regardless of the current route.
  • Now, even when currentRoute === '/', the hover and transition effects are applied correctly along with the red text color.

Fixes #280

Related Issue

None

Screenshot

Screen.Recording.2024-10-20.at.16.33.08.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
@vercel
Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bio-branch-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 11:04am
@amanreddy77
Copy link
Author

hey @subhadipbhowmik please merge my PR i solves the mentioned issue

@subhadipbhowmik subhadipbhowmik added gssoc-ext GSSoc Extended hacktoberfest-accepted Hactober Fest 2024 level1 GSSoc Extended Level 1 Points hacktoberfest Hactober Fest 2024 labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc-ext GSSoc Extended hacktoberfest Hactober Fest 2024 hacktoberfest-accepted Hactober Fest 2024 level1 GSSoc Extended Level 1 Points

2 participants