Fix destroy error on unmount #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
By always using start|stop|lock|unlockWatcher functions instead of accessing `this.watcher` directly we protect any unwanted access. It was causing errors when `autoStart` was set to false because it tried to destroy a watcher that didn’t exist.
| Add yourself as a contributor in package.json |
| Oh thanks @stutrek, you're very kind but it wasn't necessary at all. I'm going to use the contributor package so it's automatically generated and no one is forgotten, ok? 😄 |
| I also wanted a buy a little time in case you found another bug 😉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@stutrek sorry about this, but I introduced a bug with the
autoStartfeature. It was causing errors whenautoStartwas set to false and the component unmounted, because it tried to destroy a watcher that didn’t exist.So by always using start|stop|lock|unlockWatcher functions instead of accessing
this.watcherdirectly we protect any unwanted access and avoid any of these errors.Sorry again, I should have tested it more extensively!