Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .size-snapshot.json
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
{
"dist/streamsql.esm.js": {
"bundled": 8662,
"minified": 4273,
"gzipped": 1705,
"bundled": 8725,
"minified": 4301,
"gzipped": 1721,
"treeshaked": {
"rollup": {
"code": 75,
"import_statements": 0
},
"webpack": {
"code": 4866
"code": 4894
}
}
},
"dist/streamsql.cjs.js": {
"bundled": 10213,
"minified": 4843,
"gzipped": 1782
"bundled": 10276,
"minified": 4871,
"gzipped": 1798
},
"dist/streamsql.min.js": {
"bundled": 11154,
"minified": 4647,
"gzipped": 1748
"bundled": 11227,
"minified": 4675,
"gzipped": 1765
}
}
2 changes: 1 addition & 1 deletion integration/fixtures/streamsql.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/Cookies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export default class CookieJar implements CookieHandler {
oneYearFromNow.setFullYear(oneYearFromNow.getFullYear() + 1)
cookieOpts.expires = oneYearFromNow.toUTCString()
}
cookieOpts.path = cookieOpts.path || '/'
cookieOpts.secure = true
cookieOpts.sameSite = SameSite.None
this.simpleCookies.set(cookieOpts.name, cookieOpts.value)
Expand Down Expand Up @@ -85,6 +86,7 @@ export default class CookieJar implements CookieHandler {
this.setCookie({
name,
value: '',
path: '/',
maxAge: 0,
expires: epoch.toUTCString()
})
Expand Down
8 changes: 8 additions & 0 deletions src/test/cookies.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,14 @@ describe('CookieHandler', () => {
expect(document.cookie).toMatch('Secure')
})

it('sets default cookie path to /', () => {
ch.setCookie({
name: 'name',
value: 'value',
})
expect(document.cookie).toMatch('Path=/')
})

it('overrides default domain and path when set in options', () => {
ch.setCookie({
name: 'name',
Expand Down