Skip to content

Conversation

@crasite
Copy link
Contributor

@crasite crasite commented Oct 27, 2025

What does it do?

Add rate limiting documentation for users-permissions plugin on the feature page. Including description, types and default value of each parameters

Why is it needed?

The rate limiting exists but are not referenced anywhere in the documentation. It took me quite a long time to finally see why my api got rate limited (strapi/strapi#23318 (comment))

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@strapi-cla
Copy link

strapi-cla commented Oct 27, 2025

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
documentation Ready Ready Preview Comment Oct 27, 2025 5:15pm
@pwizla
Copy link
Collaborator

pwizla commented Oct 28, 2025

Thank you very for your contribution, @crasite.
I think it overlaps with some content from the admin panel rate limiting options. You do need to configure this in multiple locations but the middlewares basically work the same. I'll review your PR in the upcoming days, thank you again!

@crasite
Copy link
Contributor Author

crasite commented Oct 28, 2025

@pwizla Yes. It seem like the implementations are almost the same.
user-permission rate limit: source
admin rate limit: source

There's some inconsistency where the admin configuration use rateLimit (capital L) as the field's name and the user-permissions uses ratelimit (non-capital l)

@pwizla pwizla self-assigned this Oct 29, 2025
@pwizla pwizla added the contribution PRs that are part of the Documentation Contribution Program label Oct 29, 2025
@pwizla pwizla added this to the 6.10.0 milestone Oct 29, 2025
@pwizla
Copy link
Collaborator

pwizla commented Oct 29, 2025

You are totally right, @crasite!
Your PR is perfect, thank you very much for taking the time to dig into the Strapi codebase and help our users by providing such clear instructions 🏅 We really appreciate it.

The PR is now approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release, due today.

Also, we recently launched the Documentation Contribution Program to reward community members helping us improve the docs 🎉 Since your PR totally fits the requirements to be part of the program, the contribution label has just been added.

Basically, here's how it works: your PR, based on how many lines and files you've edited, equals to a number of points. As soon as your PR is approved and merged, you receive an email with a link to the Strapi Shop where you'll be able to purchase Strapi goodies using the points you'll have earned with your contribution 😄 Feel free to check out the Contribution Program guide for more details!

@pwizla pwizla added pr: updated content PRs updating existing documentation content source: CMS labels Oct 29, 2025
@pwizla pwizla merged commit 2e1cc43 into strapi:main Oct 29, 2025
3 of 5 checks passed
pwizla added a commit that referenced this pull request Oct 29, 2025
…2785) Co-authored-by: Thanu Poptiphueng <tpcrasite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution PRs that are part of the Documentation Contribution Program pr: updated content PRs updating existing documentation content source: CMS

3 participants