fix(addon-knobs): Knob values not properly deserialized from the URL #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| import TextType from './components/types/Text'; | ||
| import { KnobType } from './type-defs'; | ||
| | ||
| // Unused. Kept here to maintain compatibility. |
Contributor
There was a problem hiding this comment.
If this is part of the documented public API surface and no longer does anything, then a release including this PR would be a breaking change (changed behaviour). In which case it shouldn't stick around as it'll act as a source of confusion. Same goes for serializers below.
Author
There was a problem hiding this comment.
That's a good point. This isn't documented anywhere. What do you think about just removing these constants and document that they were removed?
Contributor
There was a problem hiding this comment.
SGTM, but maintainers would have the final call.
Author
There was a problem hiding this comment.
How do I get a maintainer to look at this PR? :D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1
serializemethod to return a stringdeserializemethod to take a stringdeserializefunction to take the knob component, so that itsoptionscan be matched against the serialized value.NOTE: In this PR I primarily focused on the 'Select' knob as that's the one mentioned in the bug. I tried to fix the other ones, too, but didn't focus too deeply on them.
Tested
Added unit tests for serialization/deserialization
Manually verified that copying a link and pasting it populates complex values onload.