process refs through fileSystemPath to account for os & browser

[brendarearden]

Motivation and Context

#2385

Description

Previously I had introduced this change which didn't allow for all paths to be processed appropriately.

 if (external && $Ref.is$Ref(obj)) { /* Correct the reference in the external document so we can resolve it */ let withoutHash = url.stripHash(path); if (url.isFileSystemPath(withoutHash)) { /* remove file:// from path */ withoutHash = url.toFileSystemPath(withoutHash); } obj.$ref = withoutHash + obj.$ref; } 

I had also attempted to only process browser file paths which still left windows paths broken:

 const isFileUrl = withoutHash.substr(0, 7).toLowerCase() === "file://"; if (isFileUrl) { // Strip-off the protocol withoutHash = withoutHash.substr(7); } 

and additionally added the browser path only change to the test helper #51

These were too narrow in their approach to ensure ALL paths were resolved correctly.

I am now always calling toFileSystemPath with no additional checks to ensure they are processed appropriately.
I also rolled back the changes to the test helper so it also uses the toFileSystemPath

How Has This Been Tested?

Locally on macos
Locally on windows 11 VM

Screenshot(s)/recordings(s)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• This PR's code follows as closely as possible the coding style/guidelines of this project.
• I have added error reporting and followed the error reporting guidelines.
• I have added event tracking and followed the event tracking guidelines.
• I have updated any relevant documentation accordingly to reflect this PR's changes.
• I have added automated tests (unit/integration/e2e/other) to cover my changes.
• All new and existing tests pass locally (excluding flaky CI tests).

[EdVinyard]

As @matthewmurphy and the other speed-runners say, "First try!" 😆