fix: in configForLowPower(), begin() should be call unconditionnally #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The fact RTC is already configured or not, is handled by begin() itself. Fixes stm32duino/STM32LowPower#71 Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
* RTC_initClock() must be called after reset of backup domain * NVIC interrupt enable is done within RTC_StartAlarm() to avoid cases where alarm is pending but never cleared by ISR handler * STM32RTC::begin() should get format parameter instead of period * If timer is not already set, configure an arbitrary time for Lowpower usage Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix: in configForLowPower(), begin() should be call unconditionnally
The fact RTC is already configured or not,
is handled by begin() itself.
Fixes stm32duino/STM32LowPower#71
Signed-off-by: Alexandre Bourdiol alexandre.bourdiol@st.com