Skip to content

Fix for the name change bug #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2019
Merged

Fix for the name change bug #7

merged 3 commits into from
Apr 5, 2019

Conversation

NoahRosa
Copy link
Contributor

@NoahRosa NoahRosa commented Apr 4, 2019

This PR should fix #6 with two limitations:

  1. The device name can't be more than 7 characters long. If the string passed to the begin function is longer, it is automatically trimmed to 7 characters.
  2. The android application designed to work with the SensorDemo example expects the name BlueNRG. Otherwise the device can't be opened.
@cparata
Copy link
Contributor

cparata commented Apr 4, 2019

@fpistm , what about this PR? Could we integrate it in the master repository?
fpistm
fpistm reviewed Apr 4, 2019
View reviewed changes
@fpistm
Copy link
Member

fpistm commented Apr 4, 2019

Additionnal comment, maybe the restriction could be added in the README.md and/or sketch header?
@NoahRosa
Copy link
Contributor Author

NoahRosa commented Apr 4, 2019

I modified the commit in order to include the changes you requested.
I added the limitation description both in the README.md and the sketch header.
Sorry about the comment, I added it as the last thing and forgot to recompile.
@fpistm
Copy link
Member

fpistm commented Apr 4, 2019

No worries Noah. This also happen to me. 😉
fpistm
fpistm reviewed Apr 5, 2019
View reviewed changes
@cparata cparata merged commit 1ebc418 into stm32duino:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@NoahRosa @cparata @fpistm