Compile on windows #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… defaulted special member functions h5cpp\h5cpp\H5Sall.hpp(60): error C2580: 'h5::impl::array<h5::impl::count_t,7>::array(const h5::impl::array<h5::impl::count_t,7> &)': multiple versions of a defaulted special member functions are not allowed
h5cpp\h5cpp\H5Zall.hpp(54): error C2664: 'int compress2(Bytef *,uLongf *,const Bytef *,uLong,int)': cannot convert argument 2 from 'size_t *' to 'uLongf *'
…ad it support _aligned_malloc() which must be freed with _aligned_free() from <malloc.h>. The changes fix an exception which is thrown when using aligned_alloc() on Windows.
Owner
| Hi Richard, |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi Steven,
This pull request contains three commits which allow h5cpp to compile and run using visual studio 2019.
Let me know your thoughts.
Thanks,
Richard