cli: update command line arguments (breaking change) #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
andreasgerstmayr force-pushed the fix-cli-args branch from 631c722 to c2de4be Compare 
This commit updates the CLI arguments to accept either a file containing a json pointer expression, or an expression as a commandline argument: usage: jsonpointer [-h] (-f [POINTER_FILE] | -p [POINTER]) [--indent INDENT] [-v] FILE [FILE ...] Without this commit jsonpointer "/a" a.json b.json works fine, however using a file doesn't work: $ jsonpointer -f ptr.json a.json b.json usage: jsonpointer [-h] [-f [POINTER_FILE]] [--indent INDENT] [-v] [POINTER] FILE [FILE ...] jsonpointer: error: argument POINTER: not allowed with argument -f/--pointer-file This commit also improves the usage message by explaining the mutually exclusive arguments, adds tests for the changes, updates the documentation and adds a new CHANGELOG.md file. Resolves stefankoegl#43
andreasgerstmayr force-pushed the fix-cli-args branch from c2de4be to e0c81d7 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit updates the CLI arguments to accept either a file containing
a json pointer expression, or an expression as a commandline argument:
Without this commit
works fine, however using a file doesn't work:
This commit also improves the usage message by explaining the mutually exclusive arguments,
adds tests for the changes, updates the documentation and adds a new CHANGELOG.md file.
Resolves #43