Skip to content

feat: add lapack/base/dlapy3 #7144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 2, 2025
Merged

feat: add lapack/base/dlapy3 #7144

merged 12 commits into from
Jun 2, 2025

Conversation

@aayush0325
Copy link
Member

@aayush0325 aayush0325 commented May 31, 2025

Description

What is the purpose of this pull request?

This pull request:

  • adds lapack/base/dlapy3

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers
@aayush0325
feat: add lapack/base/dlapy3
6fbb66a 
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
@aayush0325 aayush0325 marked this pull request as draft May 31, 2025 12:52
@stdlib-bot stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels May 31, 2025
@aayush0325
test: add tests
01e7ade 
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
@aayush0325 aayush0325 added GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels May 31, 2025
@aayush0325 aayush0325 marked this pull request as ready for review May 31, 2025 13:02
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 31, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented May 31, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dlapy3 $\color{green}107/107$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}107/107$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.
kgryte
kgryte requested changes Jun 1, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same general comments as dlapy2.
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 1, 2025
@aayush0325 aayush0325 mentioned this pull request Jun 2, 2025
Closed
aayush0325 added 2 commits June 2, 2025 05:22
@aayush0325
chore: code review
32f4098 
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
@aayush0325
chore: code review
f608240 
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
@kgryte kgryte added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jun 2, 2025
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
76a2f8e 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
kgryte added 3 commits June 2, 2025 16:01
@kgryte
style: remove empty line
72f4d99 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
docs: update comment
3502369 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
style: remove spaces
46726f9 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
@kgryte
docs: remove annotation
7f26f33 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
kgryte added 2 commits June 2, 2025 16:07
@kgryte
test: update messages
0ba1291 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
test: add NaN tests
56cbbc5 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 2, 2025
View reviewed changes
@kgryte
test: update description
8e58487 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 2, 2025
@kgryte kgryte merged commit fa8250e into stdlib-js:develop Jun 2, 2025
12 checks passed
anandkaranubc pushed a commit to anandkaranubc/stdlib that referenced this pull request Jun 3, 2025
@aayush0325 @kgryte @anandkaranubc
feat: add lapack/base/dlapy3
2443fd0 
PR-URL: stdlib-js#7144 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).

3 participants

@aayush0325 @stdlib-bot @kgryte