Skip to content

feat: add C implementation for math/base/special/minmax #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

feat: add C implementation for math/base/special/minmax #3206

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a8ebfa3
base code
AbhijitRaut04 Nov 21, 2024
89ffc42
base
AbhijitRaut04 Nov 21, 2024
15cb501
suggested changes made
AbhijitRaut04 Nov 21, 2024
b31e68e
applied reviewed changes
AbhijitRaut04 Nov 21, 2024
86e2ad2
update dependency
AbhijitRaut04 Nov 21, 2024
7cb88ad
minor issues solved
AbhijitRaut04 Nov 21, 2024
77cc6a3
Merge remote-tracking branch 'upstream/develop' into minmax
stdlib-bot Nov 22, 2024
a9e3098
fix: resolve lint errors
stdlib-bot Nov 22, 2024
510bd26
update benchmark.native.js
AbhijitRaut04 Nov 22, 2024
3982b00
Merge branch 'minmax' of https://github.com/AbhijitRaut04/stdlib into…
AbhijitRaut04 Nov 22, 2024
f399fed
Merge branch 'stdlib-js:develop' into minmax
AbhijitRaut04 Dec 27, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update benchmark.native.js
  • Loading branch information
@AbhijitRaut04
AbhijitRaut04 committed Nov 22, 2024
commit 510bd26c4225d39f55f9ee5a1b99d75318a3c9a3
1 change: 0 additions & 1 deletion lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/uniform' );
Copy link
Member

@gunjjoshi gunjjoshi Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbhijitRaut04 We should use @stdlib/random/array/uniform here, and declare x and y below as arrays. Then, we can can initialize them with values using randu.
Copy link
Member

@gunjjoshi gunjjoshi Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for benchmark.js as well.
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var tryRequire = require( '@stdlib/utils/try-require' );
var pkg = require( './../package.json' ).name;

Expand Down