Skip to content

refactor: update implementation for blas/base/ssymv #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 30, 2025
Merged

refactor: update implementation for blas/base/ssymv #2843

merged 13 commits into from
Aug 30, 2025

Conversation

@aman-095
Copy link
Member

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • updates implementations based on current package standards for ssymv
  • updates benchmarks, descriptions, docs, and examples for ssymv
  • updates and adds test cases supporting ndarray implementation for ssymv

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Aug 28, 2024
aman-095 and others added 2 commits August 29, 2024 00:25
@aman-095
bench: update benchmark for ndarray
7f6de04
@ShabiShett07
chore: minor clean-up
6558cc3 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 13, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/base/ssymv $\color{green}457/457$
$\color{green}+100.00\%$ 		$\color{green}61/61$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}457/457$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.
ShabiShett07 and others added 3 commits June 13, 2025 17:56
@ShabiShett07
chore: minor clean-up
8910f37 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: update test cases
73aeb86
@ShabiShett07
Merge branch 'develop' into ssymv-c
80dc810 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
Copy link
Contributor

/stdlib update-copyright-years
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 13, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 13, 2025
@ShabiShett07 ShabiShett07 marked this pull request as draft July 4, 2025 06:35
@ShabiShett07 ShabiShett07 mentioned this pull request Jul 4, 2025
Open
@ShabiShett07
Copy link
Contributor

/stdlib merge
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 7, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 7, 2025
@ShabiShett07
docs: update examples for jsdoc
e034063 
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
@ShabiShett07
chore: update markdown
1ebc801 
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
@ShabiShett07 ShabiShett07 marked this pull request as ready for review July 11, 2025 04:34
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 11, 2025
@kgryte kgryte self-requested a review July 27, 2025 11:18
@kgryte
Copy link
Member

kgryte commented Aug 28, 2025

/stdlib merge
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Aug 28, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Aug 28, 2025
@kgryte
chore: clean-up
1e1ac8c 
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 30, 2025
kgryte
kgryte approved these changes Aug 30, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some additional clean-up.
@kgryte kgryte merged commit 4dc4f6c into stdlib-js:develop Aug 30, 2025
11 checks passed
@kgryte kgryte mentioned this pull request Aug 30, 2025
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

4 participants

@aman-095 @stdlib-bot @ShabiShett07 @kgryte