chore: remove outdated lifetime TODO in rewriter proc macro #9318
+0 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This change is |
orizi approved these changes Dec 24, 2025
Collaborator
orizi left a comment
orizi left a comment There was a problem hiding this comment.
@orizi reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @VolodymyrBg).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
This change removes an obsolete TODO comment in the derive_semantic_object implementation of the rewriter proc macro. The comment referred to extracting a 'a lifetime that is no longer present in the code, which made it misleading for readers and suggested work that is already obsolete
Type of change
Please check one:
Why is this change needed?
Keeping comments in sync with the current implementation reduces noise and helps future maintainers trust the remaining TODOs.