refactor: remove redundant clones in sierra-generator #9283
+2 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This change is |
orizi approved these changes Dec 22, 2025
Collaborator
orizi left a comment
orizi left a comment There was a problem hiding this comment.
@orizi reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @0xlupin).
Collaborator
| rebase and fix, or close PR. |
orizi approved these changes Dec 24, 2025
Collaborator
orizi left a comment
orizi left a comment There was a problem hiding this comment.
@orizi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:
orizi approved these changes Dec 24, 2025
Collaborator
orizi left a comment
orizi left a comment There was a problem hiding this comment.
@orizi reviewed 1 file and all commit messages.
Reviewable status:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary clone operations in the cairo-lang-sierra-generator crate, improving performance without changing behavior.