Hardcode builtin_ty_to_vm_name. #8855
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This change is |
Contributor Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor Author
ilyalesokhin-starkware left a comment
ilyalesokhin-starkware left a comment There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
crates/cairo-lang-runnable-utils/src/builder.rs line 374 at r1 (raw file):
/// Processes the builtins required for the function parameters. fn process_builtins(&mut self, param_types: &[(GenericTypeId, i16)]) {
The goal of the PR is to make calling this function optional.
Code quote:
process_builtins
ilyalesokhin-starkware force-pushed the ilya/ty_to_name branch from 61f9e59 to 06b3f65 Compare Draft
ilyalesokhin-starkware force-pushed the ilya/ty_to_name branch from 06b3f65 to 2549515 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.