Skip to content

Conversation

@JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 28, 2025

Summary

This PR adds comprehensive documentation for the MCPRemoteProxy CRD, which enables proxying remote MCP servers in Kubernetes with authentication, authorization, audit logging, and tool filtering capabilities.

Changes

  • New documentation file: docs/toolhive/guides-k8s/remote-mcp-proxy.mdx
  • Updated sidebar: Added the new guide to the Kubernetes Operator section

Documentation Highlights

Features Covered

  • Overview and architecture diagrams
  • Enterprise use cases (SaaS MCP servers, multi-tenant access control)
  • Basic configuration with OIDC authentication
  • Multiple authentication methods (inline OIDC, ConfigMap, Kubernetes ServiceAccount)
  • Authorization policies using Cedar policy language
  • Tool filtering and renaming with MCPToolConfig
  • Token exchange for federated authentication
  • Quick start example for testing with the MCP spec server
  • Exposing proxies externally with Ingress
  • Telemetry and observability (audit logs, Prometheus, OpenTelemetry)
  • Comprehensive troubleshooting guide with 6 sections

Documentation Quality

  • Follows project style guide (US English, sentence case, Oxford comma)
  • Uses realistic enterprise examples (avoiding GitHub since it doesn't support OIDC)
  • Includes practical troubleshooting based on real deployment scenarios
  • Uses correct Kubernetes label selectors
  • Cross-references related documentation
  • All quality checks pass (Prettier, markdownlint, ESLint)

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

This commit adds comprehensive documentation for the MCPRemoteProxy CRD, which enables proxying remote MCP servers in Kubernetes with authentication, authorization, audit logging, and tool filtering capabilities. Key features documented: - Overview and use cases for enterprise SaaS MCP servers - Basic configuration with OIDC authentication - Multiple authentication methods (inline OIDC, ConfigMap, Kubernetes SA) - Authorization policies using Cedar policy language - Tool filtering and renaming with MCPToolConfig - Token exchange for federated authentication - Quick start example for testing - Exposing proxies externally with Ingress - Telemetry and observability (audit logs, Prometheus, OpenTelemetry) - Comprehensive troubleshooting guide The documentation follows the project's style guide and includes: - Realistic enterprise examples (avoiding GitHub since it doesn't support OIDC) - Practical troubleshooting based on real deployment scenarios - Correct Kubernetes label selectors verified against actual cluster resources - Cross-references to related documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings October 28, 2025 13:18
@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-website Ready Ready Preview Comment Oct 29, 2025 0:04am
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for the MCPRemoteProxy CRD, which enables Kubernetes-based proxying of remote MCP servers with enterprise features like authentication, authorization, audit logging, and tool filtering.

Key changes:

  • Introduces a new documentation page covering MCPRemoteProxy configuration, use cases, and operational guidance
  • Adds the new guide to the Kubernetes Operator section in the documentation sidebar
  • Provides practical examples for enterprise deployments with OIDC authentication and Cedar policy-based authorization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
sidebars.ts Adds the remote MCP proxy guide to the Kubernetes guides section
docs/toolhive/guides-k8s/remote-mcp-proxy.mdx New comprehensive guide covering MCPRemoteProxy setup, authentication methods, authorization policies, tool filtering, telemetry, and troubleshooting
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the documentation (human review) and I like how it flows and reads. The review agent found a couple of issues.

Fixes identified by copilot-pull-request-reviewer: 1. Clarified that principal attributes are examples from JWT tokens, with actual attributes depending on IDP configuration 2. Fixed capitalization: "User ID" instead of "user ID" 3. Improved JWT decoding command to handle base64url encoding and missing padding, with explanatory note 4. Fixed Cedar policy action names throughout: - Action::"tools/list" → Action::"list_tools" - Action::"tools/call" → Action::"call_tool" 5. Changed token exchange scope from string to array: - scope: 'analytics:read analytics:write' - scopes: ['analytics:read', 'analytics:write'] 6. Updated Prometheus metric names to match actual implementation: - toolhive_mcp_requests_total - toolhive_mcp_request_duration_seconds - toolhive_mcp_tool_calls_total - toolhive_mcp_active_connections 7. Fixed audit log JSON structure to match actual format: - Moved auditId to metadata.auditId - Moved duration_ms and transport to metadata.extra - Changed target.tool to target.name - Added required fields: loggedAt, source, component 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
@JAORMX JAORMX merged commit d7d9365 into main Oct 29, 2025
6 checks passed
@JAORMX JAORMX deleted the docs/add-mcpremoteproxy-guide branch October 29, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants