[Merged by Bors] - Enable configuration and environment overrides #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2022
siegfriedweber force-pushed the extended_configuration branch from 13aab4e to 3694b38 Compare This was referenced Apr 7, 2022
Closed
bors bot added a commit to stackabletech/product-config that referenced this pull request Apr 14, 2022
60: Add writer for configuration files in Python r=siegfriedweber a=siegfriedweber ## Description Add writer for configuration files in Python used for stackabletech/superset-operator#173 ## Review Checklist - [ ] Code contains useful comments - [ ] (Integration-)Test cases added (or not applicable) - [ ] Documentation added (or not applicable) - [ ] Changelog updated (or not applicable) Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
siegfriedweber force-pushed the extended_configuration branch from 3694b38 to 7ec3825 Compare 
* Configuration option `rowLimit` added * Configuration and environment overrides enabled
siegfriedweber force-pushed the extended_configuration branch from 7ec3825 to 81b80ad Compare 
sbernauer reviewed Apr 14, 2022
sbernauer approved these changes Apr 14, 2022
…and druid_connection_controller
| The integration tests ran successfully. |
sbernauer approved these changes Apr 14, 2022
| bors merge |
bors bot pushed a commit that referenced this pull request Apr 14, 2022
## Description * Configuration option `rowLimit` added * Configuration and environment overrides enabled
| Pull request successfully merged into main. Build succeeded: |
bors bot changed the title 6 tasks
6 tasks
bors bot pushed a commit that referenced this pull request May 13, 2022
## Description Superseding #145, completely reworked to use new configuration mechanism introduced in #173 For #5 Integration-Tests: https://github.com/stackabletech/integration-tests/pull/175 Use `./create_test_cluster.py --kind --operator superset=0.4.0-pr180` before running the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
rowLimitaddedCloses #125
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information