Skip to content

Conversation

razvan
Copy link
Member

@razvan razvan commented Oct 10, 2025

Description

Fixes #616

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker
@razvan razvan self-assigned this Oct 10, 2025
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Oct 10, 2025
@razvan razvan requested a review from a team October 10, 2025 08:48
@razvan razvan enabled auto-merge October 10, 2025 08:49
sbernauer
sbernauer previously approved these changes Oct 10, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks and thanks for the test!
It would be nice if you could also assert the used ServiceAccount on the created Pods

@razvan razvan added this pull request to the merge queue Oct 10, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 10, 2025
@sbernauer sbernauer removed this pull request from the merge queue due to a manual request Oct 10, 2025
@razvan
Copy link
Member Author

razvan commented Oct 10, 2025

Nice fix, thanks and thanks for the test! It would be nice if you could also assert the used ServiceAccount on the created Pods

done

sbernauer
sbernauer previously approved these changes Oct 10, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry, I didn't know the assertion would be this complicated...

@razvan
Copy link
Member Author

razvan commented Oct 10, 2025

I had another typo but now ...

--- PASS: kuttl (101.23s) --- PASS: kuttl/harness (0.00s) --- PASS: kuttl/harness/overrides_openshift-false_spark-3.5.6 (99.72s) PASS 
@razvan razvan requested a review from sbernauer October 10, 2025 09:47
@razvan razvan enabled auto-merge October 10, 2025 09:49
@razvan razvan added this pull request to the merge queue Oct 10, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 10, 2025
Merged via the queue into main with commit f4b00b7 Oct 10, 2025
17 checks passed
@razvan razvan deleted the issues/616 branch October 10, 2025 10:35
@lfrancke
Copy link
Member

Please add a release note snippet in the form "Previously, this went wrong. With this release, this was fixed in the following way."

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Oct 14, 2025
@razvan
Copy link
Member Author

razvan commented Oct 14, 2025

Release Note

The service account of spark applications can now be overridden with pod overrides.

Previously the application service account was passed as command line argument to spark-submit
and was thus not possible to overwrite with pod overrides for the driver and executors.
This CLI argument has now been moved to the pod templates of the individual roles.

@razvan razvan added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/25.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

3 participants