Skip to content

Conversation

nightkr
Copy link
Contributor

@nightkr nightkr commented Jan 25, 2024

Description

Fixes #93

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [x] Changes are OpenShift compatible - [x] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) - [x] Changes need to be "offline" compatible 
# Reviewer - [x] Code contains useful comments - [ ] (Integration-)Test cases added - [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide). - [x] Changelog updated - [x] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added 
@nightkr
Copy link
Contributor Author

nightkr commented Jan 25, 2024

It works:tm:, still need to do docs and configuration.

@nightkr nightkr requested a review from a team January 26, 2024 15:37
@nightkr nightkr marked this pull request as ready for review January 26, 2024 15:38
@nightkr
Copy link
Contributor Author

nightkr commented Jan 26, 2024

Not sure how to test this properly, "just let the test wait for two years" obviously isn't a viable strategy.

We could at least test certificate selection by setting up some static certificates in the test suite, but having them be completely static wouldn't work either (since the correct certificate to choose depends on the system time).

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Tested manually by lowering the constant times and successfully rolled over 👍

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and seems to work.

I would prefer having kuttl tests for this (#354 might help), as we will probably never run into CA rollovers in our tests, but I can see this being hard...

@nightkr nightkr enabled auto-merge January 29, 2024 13:47
@nightkr nightkr added this pull request to the merge queue Jan 29, 2024
@sbernauer sbernauer added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/24.3.0 and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. release/24.3.0 labels Jan 29, 2024
@nightkr
Copy link
Contributor Author

nightkr commented Jan 29, 2024

Created #355 for the testing.

Merged via the queue into main with commit a43bc97 Jan 29, 2024
@nightkr nightkr deleted the feature/ca-rotation branch January 29, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants