Skip to content

[Merged by Bors] - Allow configuring CSI docker images #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Allow configuring CSI docker images #235

wants to merge 4 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Feb 8, 2023 •
edited
Loading

Description

Additional things:

  • Mirrored images to our registry
  • Bumped csi-node-driver-registrar 2.4.0 -> 2.5.0
  • Fixed User "system:serviceaccount:default:secret-operator-serviceaccount" cannot patch resource "events" i n API group "" in the namespace "default"

Tested version secret=0.7.0-pr235 in kind

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information
@sbernauer sbernauer marked this pull request as ready for review February 8, 2023 14:49
@sbernauer sbernauer requested a review from nightkr February 8, 2023 14:49
nightkr
nightkr approved these changes Feb 8, 2023
View reviewed changes
@sbernauer sbernauer force-pushed the feature/configure-csi-images branch from 34de0ef to 923340d Compare February 8, 2023 15:03
@sbernauer
Copy link
Member Author

bors r+
bors bot pushed a commit that referenced this pull request Feb 8, 2023
@sbernauer
Allow configuring CSI docker images (#235)
1c4eb17 
# Description Additional things: * Mirrored images to our registry * Bumped `csi-node-driver-registrar` 2.4.0 -> 2.5.0 * Fixed `User "system:serviceaccount:default:secret-operator-serviceaccount" cannot patch resource "events" i n API group "" in the namespace "default"` Tested version `secret=0.7.0-pr235` in kind
@sbernauer sbernauer self-assigned this Feb 8, 2023
@bors
Copy link
Contributor

bors bot commented Feb 8, 2023

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title Allow configuring CSI docker images [Merged by Bors] - Allow configuring CSI docker images Feb 8, 2023
@bors bors bot closed this Feb 8, 2023
@bors bors bot deleted the feature/configure-csi-images branch February 8, 2023 15:08
@lfrancke
Copy link
Member

Is this something for the feature tracker?
Probably not because only internal...
@sbernauer
Copy link
Member Author

I would consider it a minor thing that we missed previously
@nightkr nightkr mentioned this pull request Mar 14, 2023
Closed
@sbernauer sbernauer mentioned this pull request Mar 14, 2023
Closed
bors bot pushed a commit to stackabletech/listener-operator that referenced this pull request Mar 14, 2023
@sbernauer
Allow configuring CSI docker images (#61)
d455176 
# Description Fixes #60. For https://github.com/orgs/stackabletech/discussions/14 Backport of stackabletech/secret-operator#235 for listener-operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-request release/23.4.0

3 participants

@sbernauer @lfrancke @nightkr