Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Mar 17, 2024

This adds a new helper for running tests called script/run-tests.

This script takes the same arguments as the old scripts/run_tests.sh but improves
it's behavior in a few ways.

It enables users to run custom CI tests in Jenkins without having to patch
the release.yaml file in pull requests.

This is possible given a new argument --operator <name>=<version>. When provided,
the operator version specified om the command line is installed instead of
the version present in the release.yaml file.

See ./script/run-tests --help for more information.

It also solves the problem that stackablectl doesn't exit with a non-zero code
on failure and therefor the CI pipeline may continue to run with a broken
operator installation.

@razvan razvan requested a review from a team March 17, 2024 17:43
@soenkeliebau soenkeliebau self-assigned this Mar 18, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not review the code properly (as @soenkeliebau assigned himself), but the functionality looks good to me, thanks!

@soenkeliebau soenkeliebau removed their assignment Mar 19, 2024
@razvan razvan added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit 63572a8 Mar 19, 2024
@razvan razvan deleted the fix/new-test-script branch March 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants