Skip to content

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Apr 1, 2025

Description

Part of stackabletech/issues#639.

  • BREAKING: Add required filename_suffix field.
  • Allow the rotation period to be configurable (defaults to Never).
  • Allow configuring the max_log_files value.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [x] Integration tests passed (for non trivial changes) 
# Reviewer - [ ] Code contains useful comments - [ ] (Integration-)Test cases added - [ ] Documentation added or updated - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added 
@NickLarsenNZ NickLarsenNZ moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Apr 1, 2025
@NickLarsenNZ NickLarsenNZ requested a review from Techassi April 1, 2025 12:33
@NickLarsenNZ NickLarsenNZ changed the title feat(stackable-telemetry): Allow customization of the rolling file appender rotation period feat(stackable-telemetry): Allow customization of the rolling file appender Apr 1, 2025
@NickLarsenNZ NickLarsenNZ changed the title feat(stackable-telemetry): Allow customization of the rolling file appender feat(stackable-telemetry)!: Allow customization of the rolling file appender Apr 1, 2025
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 1, 2025
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Apr 1, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Apr 1, 2025
Merged via the queue into main with commit 3374ae1 Apr 1, 2025
9 of 10 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Apr 1, 2025
…ppender (#995) * feat(stackable-telemetry): Allow customization of the rolling file appender rotation period * chore(stackable-telemetry): Update changelog * feat(stackable-telemetry): Add required file appender filename_suffix field * feat(stackable-telemetry): Allow customization of the rolling file appender max log files * chore(stackable-telemetry): Mark change as breaking * feat(stackable-telemetry): Complete the sentence * feat(stackable-telemetry): Add punctuation * chore(stackable-telemetry): Replace generic parameters with impls
@NickLarsenNZ NickLarsenNZ deleted the feat/stackable-telemetry-file-appender-rotation-period branch April 1, 2025 15:07
Techassi added a commit that referenced this pull request Apr 1, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2025
…996) * chore: Release stackable-operator 0.88.0, stackable-versioned 0.7.1 * test: Fix rolling log file doc and unit test This was missed in #995. * chore: Update changelog * chore: Update release date
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants