Skip to content

Conversation

@Techassi
Copy link
Member

@Techassi Techassi commented Feb 20, 2025

Part of stackabletech/issues#642

This PR unifies the option interface and moves the preserve_module option (which is only available when the macro is used on modules) into the list of options().

Before

#[versioned(  version(name = "v1alpha1"),  preserve_module )] mod versioned { pub struct Foo { bar: Option<u16>, } }

After

#[versioned(  version(name = "v1alpha1"),  options(preserve_module) )] mod versioned { pub struct Foo { bar: Option<u16>, } }
@Techassi Techassi self-assigned this Feb 20, 2025
@Techassi Techassi changed the title refactor: Move preserve_module into options() refactor(stackable-versioned): Move preserve_module into options() Feb 20, 2025
@Techassi Techassi marked this pull request as ready for review February 20, 2025 14:27
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 6b6f802 Feb 21, 2025
10 checks passed
@Techassi Techassi deleted the refactor/preserve_module-arg branch February 21, 2025 10:30
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants