refactor: Change Deref target of KeyPrefix and KeyName to str #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sbernauer reviewed Jan 23, 2024
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
NickLarsenNZ previously approved these changes Jan 23, 2024
Member
NickLarsenNZ left a comment
NickLarsenNZ left a comment There was a problem hiding this comment.
LGTM - only thing that is arguably missing would be a test to show how it gets used (eg: stackabletech/hdfs-operator#454 (comment))
Member Author
| Sure, I can add a few tests which should cover the use-case you mentioned in |
NickLarsenNZ previously approved these changes Jan 23, 2024
sbernauer previously approved these changes Jan 23, 2024
Member Author
| Added some tests, ready for review again. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Came up in stackabletech/hdfs-operator#454.