-
- Notifications
You must be signed in to change notification settings - Fork 16
feat: Add key/value pair validation #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| We ideally want the creation of a K/V pair to be available in Having K/V pair creation available in The API is very close to it's final form. One open point is the usage of the new API in other |
NickLarsenNZ left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good
NickLarsenNZ left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| When would the former API be used? What hole is it trying to fill? |
| There is currently no immediate benefit from the first option, but in the future we might stumble over that kind of input, like from a file, or command line argument. |
| Then we can consider the problem when it actually arises. We shouldn't preemptively make it easier to do the wrong thing just in case. |
NickLarsenNZ left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I like the contains and contains_key that take an impl TryInto. Makes the usage really clean.
Fixes #614, supersedes #615, part of stackabletech/issues#188
This PR adds mechanisms to safely create key/value pairs (labels and annotations). These enable us to attach a unified set of labels to deployed resources. The set of labels make it to possible to track resources installed by us, which in turn enables us to list, modify and delete resources with our management tools, namely
stackablectl, and in the futurestackable-cockpit.