feat: Add gracefulShutdownTimeout to GenericRoleConfig #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sbernauer changed the title 
Techassi reviewed Oct 9, 2023
| | ||
| /// Time period the Pods of this role have to gracefully shut down, e.g. `1h`, `30m` or `2d`. | ||
| /// Consult the individual operator documentation for details on how the graceful shutdown | ||
| /// mechanism works. |
Member
There was a problem hiding this comment.
Maybe mention the default value here.
Member Author
| Not needed any more, as we track gracefulShutdownTimeout in the product specific |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#357
Definition of Done Checklist