[Merged by Bors] - feat: add Display for ClusterCondition #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sbernauer reviewed Jun 20, 2023
sbernauer reviewed Jun 20, 2023
sbernauer reviewed Jun 20, 2023
Member Author
| bors r+ |
bors bot pushed a commit that referenced this pull request Jun 21, 2023
This PR adds a `Display` impl for `ClusterCondition`. It might be worth a thought that we want to provide different `display_*` methods for various levels of verbosity. Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>
Contributor
| Pull request successfully merged into main. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors bot changed the title bors bot pushed a commit that referenced this pull request Jun 21, 2023
The display string for the `ReconciliationPaused` was swapped. This fixes the display impl introduced in #608. Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a
Displayimpl forClusterCondition. It might be worth a thought that we want to provide differentdisplay_*methods for various levels of verbosity.