Improve logging #54
Merged
Improve logging #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…est and improve logging in general
soenkeliebau approved these changes Feb 10, 2021
Member
soenkeliebau left a comment
soenkeliebau left a comment There was a problem hiding this comment.
LGTM - just one note that we might think about but that is just because it occurred to me here
| Err(ref err) => { | ||
| // If we get here it means that our `reconcile` method returned an error which should never happen because | ||
| // we convert all errors to requeue operations. | ||
| error!(?err, "Reconciliation finished with an error, this should not happen, please file an issue") |
Member
There was a problem hiding this comment.
Random brainfart, we are calling for people to file issues in some places, should we keep track of these places somewhere and give them an identifier that people can reference or something similar?
Nothing to do about this here, just a thought to be discussed.
Member Author
There was a problem hiding this comment.
Yeah...we should reactivate our common logging thing but that's probably very much outdated by now. It's a good idea though.
Member Author
| Oh, I'm sorry, not sure why I added you as a reviewer. This is still a draft but it looks good so it can probably go in as well. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Create a span for each new reconcile, assign a unique id to each request and improve logging in general